POST request to an API #111

harshakhmk · 2021-06-12T13:33:44Z

Related Issue

Closes: #https://github.com/IndianOpenSourceFoundation/dynamic-cli/issues/76

Describe the changes you've made

Added POST request and implemented various ways to send payload data

Checklist:

My code follows the style guidelines of this project.
I have performed a self-review of my own code.
I have commented on my code, particularly in hard-to-understand areas.
I have made corresponding changes to the documentation.
My changes generate no new warnings.

harshakhmk · 2021-06-12T17:12:57Z

@GouravSardana @pranavbaburaj @NamamiShanker review pls

lainq

Thank you for contributing to dynamic cli. I have added some review comments. Please let me know your thoughts. 🙂

src/arguments/api_test.py

GouravSardana · 2021-06-12T17:29:31Z

Share a GIF or some video to show on various input. So that other can also see how they can use it ?

GouravSardana

Please make these small changes and really thankful for your contribution. Great work 🥇

GouravSardana · 2021-06-12T17:31:58Z

src/arguments/api_test.py

+                 cls.read_data_from_file()
+    @classmethod
+    def fetch_payload_data(cls):
+        store = int(input("Please choose the below options? (1/2/3)"))


Can we add a option here ?
Do you want to send payload Y/N
Then we can display option like send a payload from terminal or file

then there would be multiple conditions

if yes : enter 1 to send from terminal enter 2 to read from terminal any other number #then again we have to repeat from starting line, if you want to send payload elif no return else recur the function

Do we also send bearer token in this payload ?

yeah if the user sends it

GouravSardana · 2021-06-12T17:32:58Z

src/arguments/api_test.py

@@ -84,6 +116,20 @@ def get_request(cls):
            print(cls.invalid_schema_message)
        except Exception as exception_obj:
            print(exception_obj)
+    #Make a POST request


Add 2 space above. Follow pep8 formatting please

GouravSardana · 2021-06-12T17:33:17Z

src/arguments/api_test.py

+        request_data = cls.fetch_input_url()
+        data = cls.fetch_payload_data()
+        try:
+            response= requests.post(url = request_data["request_url"], headers= request_data["request_headers"], data = data)


Add a space before = (equals)

everything can be done, using black formatter I guess, shall we try adding it

yes, you can use the black formatter locally on your system before pushing it 😃

harshakhmk · 2021-06-13T02:50:38Z

Share a GIF or some video to show on various input. So that other can also see how they can use it ?

It's not working on my OS

GouravSardana · 2021-06-13T02:55:19Z

How do you test it then ?

harshakhmk · 2021-06-13T03:37:28Z

How do you test it then ?

I tried testing in gitpod, running into errors, new to Linux environment

GouravSardana · 2021-06-13T16:00:21Z

No issues. I'll test it before merge @harshakhmk . You can make your changes which are requested

harshakhmk · 2021-06-13T17:01:12Z

No issues. I'll test it before merge @harshakhmk . You can make your changes which are requested

@GouravSardana Thank you for understanding

harshakhmk · 2021-06-14T07:21:10Z

I have made the suggested changes

src/arguments/api_test.py

harshakhmk · 2021-06-15T05:51:00Z

Any other changes?

lainq

Any other changes?
I think, no. @GouravSardana, please let us know what you think!

GouravSardana · 2021-06-15T10:53:30Z

Some Suggestions from my end -

In Screenshot 1 - I could not see 3 options when I clicked on Y.
In screenshot 2 - When I click on 1 then I'll see only 2 options then why did you give 3 options?
In screenshot 3 - When I give a file name. It could not read. It's very painful to add full pathname without having tab access [tab will give autocomplete file in the current folder].
In the last screenshot - When typing in the terminal we can give one more option to open a nano editor and the user can directly copy-paste the JSON which he has. For more info- How to open a nano editor, You can have a subprocess when the user hits option 4 [Option 4 is to open a nano editor to give the input payload] and the User can simply type and exit the nano and It will get the payload from the nano file. You can read this

GouravSardana

I request the changes above, Please work on it

GouravSardana · 2021-06-15T10:55:06Z

For testing any End Point - You can use this - https://reqres.in/

lainq · 2021-06-15T12:05:55Z

Oh, my bad. Strings don't have an attribute called trim. 🤦🏾‍♂️

if len(filename.strip()) == 0:            
    print("filename empty, so default file (response_data.json) is used ")

I had the wrong method in the example. I am sorry 😐

harshakhmk · 2021-06-18T15:13:01Z

The First 3 issues were resolved, for the time being can we add issue 4 as a new feature in a separate PR @GouravSardana
It can be used in PUT request as well

GouravSardana · 2021-06-18T17:33:37Z

Did you push your changes after doing these first 3 issues

harshakhmk · 2021-06-19T17:43:10Z

@GouravSardana yes, I have updated the code

GouravSardana · 2021-06-20T04:21:26Z

I'll try it locally once. If everything went well. I'll merge it. Please create an issue for the last screenshot requirement which i have shared above

lainq

I think it's good. 🙂

src/arguments/api_test.py

sonarqubecloud · 2021-06-20T11:46:25Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

GouravSardana · 2021-06-21T10:03:08Z

Everything looks good. Thanks for the contribution @harshakhmk

harshakhmk added 3 commits June 12, 2021 18:58

Add POST endpoint

f197196

Branch update with recent changes

079efbc

Fix codacy issues

78c4c44

lainq reviewed Jun 12, 2021

View reviewed changes

src/arguments/api_test.py Outdated Show resolved Hide resolved

src/arguments/api_test.py Outdated Show resolved Hide resolved

GouravSardana requested changes Jun 12, 2021

View reviewed changes

harshakhmk added 2 commits June 13, 2021 23:15

Fix code as per review

a3579e4

Fix codacy issues

6a26b96

harshakhmk requested review from GouravSardana and lainq June 14, 2021 07:20

lainq reviewed Jun 14, 2021

View reviewed changes

src/arguments/api_test.py Outdated Show resolved Hide resolved

lainq reviewed Jun 15, 2021

View reviewed changes

GouravSardana requested changes Jun 15, 2021

View reviewed changes

Update code as per commit

bc65db9

harshakhmk requested a review from GouravSardana June 20, 2021 10:52

harshakhmk requested a review from lainq June 20, 2021 10:52

lainq reviewed Jun 20, 2021

View reviewed changes

src/arguments/api_test.py Outdated Show resolved Hide resolved

handled strip method

ae3b81e

GouravSardana merged commit 71004e8 into IndianOpenSourceFoundation:master Jun 21, 2021

GouravSardana mentioned this pull request Jun 21, 2021

Open a nano editor while uploading the Payload in POST #112

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

POST request to an API #111

POST request to an API #111

harshakhmk commented Jun 12, 2021

harshakhmk commented Jun 12, 2021

lainq left a comment

GouravSardana commented Jun 12, 2021

GouravSardana left a comment

GouravSardana Jun 12, 2021

harshakhmk Jun 13, 2021

GouravSardana Jun 13, 2021

harshakhmk Jun 13, 2021

GouravSardana Jun 12, 2021

GouravSardana Jun 12, 2021

harshakhmk Jun 13, 2021

lainq Jun 13, 2021

harshakhmk commented Jun 13, 2021

GouravSardana commented Jun 13, 2021

harshakhmk commented Jun 13, 2021

GouravSardana commented Jun 13, 2021

harshakhmk commented Jun 13, 2021

harshakhmk commented Jun 14, 2021

harshakhmk commented Jun 15, 2021

lainq left a comment

GouravSardana commented Jun 15, 2021

GouravSardana left a comment

GouravSardana commented Jun 15, 2021

lainq commented Jun 15, 2021

harshakhmk commented Jun 18, 2021

GouravSardana commented Jun 18, 2021

harshakhmk commented Jun 19, 2021

GouravSardana commented Jun 20, 2021

lainq left a comment

sonarqubecloud bot commented Jun 20, 2021

GouravSardana commented Jun 21, 2021

POST request to an API #111

POST request to an API #111

Conversation

harshakhmk commented Jun 12, 2021

Related Issue

Describe the changes you've made

Checklist:

harshakhmk commented Jun 12, 2021

lainq left a comment

Choose a reason for hiding this comment

GouravSardana commented Jun 12, 2021

GouravSardana left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

harshakhmk commented Jun 13, 2021

GouravSardana commented Jun 13, 2021

harshakhmk commented Jun 13, 2021

GouravSardana commented Jun 13, 2021

harshakhmk commented Jun 13, 2021

harshakhmk commented Jun 14, 2021

harshakhmk commented Jun 15, 2021

lainq left a comment

Choose a reason for hiding this comment

GouravSardana commented Jun 15, 2021

GouravSardana left a comment

Choose a reason for hiding this comment

GouravSardana commented Jun 15, 2021

lainq commented Jun 15, 2021

harshakhmk commented Jun 18, 2021

GouravSardana commented Jun 18, 2021

harshakhmk commented Jun 19, 2021

GouravSardana commented Jun 20, 2021

lainq left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jun 20, 2021

GouravSardana commented Jun 21, 2021